packages/schemas/src/setup/setup.ts (2)

126-126: 💤 Low value

sectionsOrder allows duplicate sections.

The schema permits arrays like ['logo', 'logo', 'name']. If duplicates would cause rendering issues, add a refinement.

♻️ Optional: add uniqueness check

-  sectionsOrder: z.array(z.enum(PANEL_SECTIONS)).max(5).optional(),
+  sectionsOrder: z.array(z.enum(PANEL_SECTIONS)).max(5).refine(
+    (arr) => new Set(arr).size === arr.length,
+    'Section order must not contain duplicates'
+  ).optional(),

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/schemas/src/setup/setup.ts` at line 126, The sectionsOrder schema
currently allows duplicate entries (e.g., ['logo','logo','name']); update the
z.array(z.enum(PANEL_SECTIONS)).max(5).optional() definition to enforce
uniqueness by adding a refinement that checks the array has no duplicates (e.g.,
compare new Set(value).size to value.length) and provide a clear error message;
keep the existing .max(5) and .optional() and apply the refinement on the same
symbol sectionsOrder so callers get validation failures for duplicate sections.

---

57-60: 💤 Low value

$ResourceLink lacks URL format validation on href.

href accepts any non-empty string up to 2000 chars. Malformed URLs or non-URL strings could slip through. Consider adding .url() if only valid URLs are acceptable.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/schemas/src/setup/setup.ts` around lines 57 - 60, The $ResourceLink
schema's href currently allows any non-empty string; update the href validator
to enforce URL format by replacing z.string().min(1).max(2000) with
z.string().url().max(2000) (or z.string().url().min(1).max(2000) if you want to
keep the explicit min), so the $ResourceLink object only accepts well-formed
URLs; locate the $ResourceLink definition to apply this change.

apps/web/src/components/LoginBranding/LoginBrandingPanel.tsx (2)

247-262: 💤 Low value

Consider using index-only key for resource links.

Line 255 generates keys as ${link.href}-${index}, but if two links share the same href, React will warn about duplicate keys. Since the array is admin-controlled and the order is stable, using index alone is sufficient.

🔑 Proposed fix

-            key={`${link.href}-${index}`}
+            key={index}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/web/src/components/LoginBranding/LoginBrandingPanel.tsx` around lines
247 - 262, In LoginBrandingPanel update the map over branding!.resourceLinks! to
use the array index as the React key instead of `${link.href}-${index}` to avoid
duplicate-key warnings when two links share the same href; locate the JSX block
inside the resourceLinks.map in the LoginBrandingPanel component and replace the
key prop with just the index (e.g., key={index}), as the array is
admin-controlled and order is stable.

---

83-84: 💤 Low value

Consider consistent empty-string handling.

Lines 82, 83, and 84 handle empty strings differently: instanceName uses || to treat empty strings as missing (falling back to the default), while instanceTagline and instanceDetails use ?? which preserves empty strings. Since all three call .trim(), an empty or whitespace-only string becomes '', which is falsy and won't render in the JSX conditions (lines 202, 217). However, the inconsistency may confuse future maintainers.

🔄 Proposed consistency fix

-  const instanceTagline = branding?.instanceTagline?.[lang]?.trim() ?? null;
-  const instanceDetails = branding?.instanceDetails?.[lang]?.trim() ?? null;
+  // eslint-disable-next-line `@typescript-eslint/prefer-nullish-coalescing`
+  const instanceTagline = branding?.instanceTagline?.[lang]?.trim() || null;
+  // eslint-disable-next-line `@typescript-eslint/prefer-nullish-coalescing`
+  const instanceDetails = branding?.instanceDetails?.[lang]?.trim() || null;

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/web/src/components/LoginBranding/LoginBrandingPanel.tsx` around lines 83
- 84, The three variables instanceName, instanceTagline, and instanceDetails are
handled inconsistently: instanceName uses || to treat empty/whitespace-only
strings as missing while instanceTagline and instanceDetails use ?? which
preserves empty strings; make them consistent by applying the same empty-string
fallback logic to instanceTagline and instanceDetails (e.g., after .trim()
coerce '' to null or fallback value the same way instanceName does) so JSX
rendering conditions behave uniformly.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes